#15185: Clean up interface to the PARI library
-------------------------+-------------------------------------------------
Reporter: | Owner:
pbruin | Status: new
Type: | Milestone: sage-5.13
enhancement | Resolution:
Priority: major | Merged in:
Component: | Reviewers:
interfaces | Work issues: wait for #10018
Keywords: pari | Commit:
Authors: | 2344f0bd14b5f72eb84ad1b134f84a74de25fc2e
Report Upstream: N/A | Stopgaps:
Branch: |
u/pbruin/15185 |
Dependencies: #9640 |
#10018 |
-------------------------+-------------------------------------------------
Description changed by pbruin:
Old description:
> The file `sage/libs/pari/gen.pyx` is too big and contains too many
> different things. For clarity and maintainability, it should be split
> into three parts:
> - `gen.pyx` containing the class `gen`;
> - `pari_error.pyx` containing the class `PariError` and other error-
> handling code;
> - `pari_instance.pyx` containing the class `PariInstance` and some
> utility functions.
> The following things should probably be cut out:
> - The `gen` class currently contains duplicates of various methods of
> `PariInstance` (such as `new_gen`) for no obvious reason. These methods
> should be deleted.
> - The global variables `t0, ..., t5` (used to store results of conversion
> of Python objects to PARI objects) should be replaced by appropriate
> local variables.
> - There is a lot of obsolete code (e.g. `add_unsafe`, which currently is
> not used, and probably never should be); this should be deleted.
> A patch is being worked on; it does not work well with the existing
> error-handling code and should be rebased on #9640.
New description:
The file `sage/libs/pari/gen.pyx` is too big and contains too many
different things. For clarity and maintainability, it should be split
into two or three parts:
- `gen.pyx` containing the class `gen`;
- `pari_instance.pyx` containing the class `PariInstance` and some utility
functions;
- (maybe) `pari_error.pyx` containing the class `PariError`.
In addition, this ticket makes the following changes:
- The `gen` class currently contains duplicates of various methods of
`PariInstance` (such as `new_gen`) for no obvious reason. These methods
will be deleted.
- Replace the global variables `t0, ..., t5` (used to store results of
conversion of Python objects to PARI objects) by appropriate local
variables.
- Remove obsolete code (e.g. `add_unsafe`, which currently is not used,
and probably never should be).
--
--
Ticket URL: <http://trac.sagemath.org/ticket/15185#comment:4>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/groups/opt_out.
