#5997: [with patch, needs review] deprecate the "order" method on elements of
rings.
-------------------------+--------------------------------------------------
Reporter: was | Owner: tbd
Type: enhancement | Status: new
Priority: minor | Milestone: sage-4.0
Component: algebra | Keywords:
-------------------------+--------------------------------------------------
Comment(by mvngu):
REFEREE REPORT
[[BR]][[BR]]
The patch {{{trac_5997.patch}}} applies OK against the "post-final"
sage-3.4.2 and all doctests pass with the options {{{-t -long}}}. Now say
we create an element in {{{Z/12Z}}} like so:
{{{
sage: a = Integers(12)(5)
}}}
Then both {{{a.order()}}} and {{{ a.additive_order()}}} return the same
result, but {{{a.order()}}} additionally gives a deprecation warning:
{{{
sage: a.order()
/scratch/mvngu/sage-3.4.2-sage.math-only-x86_64-Linux/local/lib/python2.5
/site-packages/IPython/iplib.py:2073: DeprecationWarning: The function
order is deprecated for ring elements; use additive_order or
multiplicative_order instead.
exec code_obj in self.user_global_ns, self.user_ns
12
}}}
[[BR]][[BR]]
However, there's one trivial typo in the patch. This is fixed in the
reviewer patch {{{trac_5997-reviewer.patch}}}. Basically, I give positive
review to John's patch. Only my patch needs to be reviewed.
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/5997#comment:4>
Sage <http://sagemath.org/>
Sage - Open Source Mathematical Software: Building the Car Instead of
Reinventing the Wheel
--~--~---------~--~----~------------~-------~--~----~
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To post to this group, send email to [email protected]
To unsubscribe from this group, send email to
[email protected]
For more options, visit this group at
http://groups.google.com/group/sage-trac?hl=en
-~----------~----~----~----~------~----~------~--~---
