#15466: Remove deprecated code from combinat/
-------------------------------------+-------------------------------------
Reporter: ncohen | Owner:
Type: defect | Status: positive_review
Priority: major | Milestone: sage-6.0
Component: combinatorics | Resolution:
Keywords: | Merged in:
Authors: Nathann Cohen | Reviewers: Andrew Mathas
Report Upstream: N/A | Work issues:
Branch: | Commit:
u/andrew.mathas/ticket/15466 | 6639e7543dc6399280c5e42babca5eff18584da9
Dependencies: #15467 | Stopgaps:
-------------------------------------+-------------------------------------
Changes (by ncohen):
* status: needs_review => positive_review
Comment:
Yooooooooooo !!
> Hi Nathann, thanks for starting this (or should that be
thaaaaaaaaaaaanks!:).
Well I'm glad to receive your help with this ! `:-D`
> I found a few more depreciated [sic] functions to remove in the words
subdirectory and I moved a few import statements of `deprecation` so that
they are now immediately above the function call. This will help ensure
that there are no stray {{{deprecation}}} import statements left when the
corresponding soon-to-be-depreciated code is removed.
GoodGoodGood !
> Finally, I killed off some documentation for some functions that are
removed by this patch.
Argggg ! Nice job spotting that `;-)`
By the way : these days I use the --warn-links flag when building the doc.
It tells you whenever some links are made toward non-existent functions. I
guess it will be useful to spot things like that in the future, when this
--warn-links will be a default, though right now there are too many broken
lins in Sage to make it the default `:-)`
> If you are happy with my changes let's make this a positive review. I've
bumped the version number to 6 since we're using git.
The tests passed while I was reading the patch. Good to go, thanks `:-)`
> [ps I have checked all of the doctsts in sage/combinat. I do get a
doctext failure in {{{root_system/coxeter_group.py}}} but I get the same
failure in master, so I think it has nothing to do with this ticket.]
Hmmmmm.. I don't get this error. Though at some point Volker told me that
I should run "make" again in Sage's directory to update the spkg which may
have changed since. Do give it a try when you don't need to use Sage for a
while (it will recompile a lot of things). I used to have a couple of
broken doctests, and it solved it !
Thank you again, and positive review to this patch ! `;-)`
Nathann
--
Ticket URL: <http://trac.sagemath.org/ticket/15466#comment:6>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/groups/opt_out.
