#15491: directed immutable graphs report twice too many edges
-------------------------+-------------------------------------------------
Reporter: | Owner:
ncohen | Status: needs_review
Type: | Milestone: sage-5.13
defect | Resolution:
Priority: major | Merged in:
Component: graph | Reviewers:
theory | Work issues:
Keywords: | Commit:
Authors: | 020cc82f8f9ba8bc8295ac1e79c396a12a4a5fd8
Nathann Cohen | Stopgaps:
Report Upstream: N/A |
Branch: |
u/ncohen/15491 |
Dependencies: |
-------------------------+-------------------------------------------------
Comment (by SimonKing):
Replying to [comment:5 ncohen]:
> Okay. Just to make things clear, I don't like this function, ...
I don't like it either, but I do like if equal graphs evaluate equal.
> `cg.g.edges` is not equal to the number of edges. It is a pointer toward
the beginning of the `edges` array. `cg.g.edges` is actually equal to
`cg.g.neighbors[0]`. I added a line of doc to emphasize it. I'm
substracting pointers there, not integers.
Aha, I see. Pointers are mind bending.
>
> Which trailing whitespace ? `O_o`
> You mean the spaces just before the `"` ? If I remove them you will see
"expectedin" and "thinkthat" when the message is displayed.
Yes, I have not been aware that Python lets you do those things. I thought
that
{{{
("h"
"e"
"l"
"l"
"o")
}}}
is a syntax error, but it results in 'hello'.
> I added a doctest to make this clear.
Good idea.
> There is no occurrence of " : " in this file,
There is one in the doc string that I cited.
> the english complain when I put spaces, the french when I don't.
I don't like imposing rules of one language to another language. There are
stories of Germans named, e.g., "Müller", having problems with US cops,
because the cops wouldn't even notice that there are dots over the "u" in
the guy's passport, and would certainly not accept that the correct way to
spell this German name on a keyboard without Umlaut is "Mueller" and not
"Muller". Actually I hate myself for writing "Groebner" instead of
"Gröbner" in Sage doc strings (but at least I don't write "Grobner").
Of course, errors can occur, specifically when writing text in a foreign
language, and an extra space certainly is not a big drama (I am ''not''
calling you an imperialist : `:-P`). Since the above mentioned doc string
is from `static_sparse_graph.pyx` and thus from a file that your commits
don't touch, I'd say one shouldn't try to fix it here.
--
Ticket URL: <http://trac.sagemath.org/ticket/15491#comment:7>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/groups/opt_out.
