#15506: Fix another "recursion depth exceeded" in memory deallocation for weak
dictionaries
-------------------------------------+-------------------------------------
Reporter: nthiery | Owner:
Type: defect | Status: positive_review
Priority: major | Milestone: sage-6.1
Component: performance | Resolution:
Keywords: | Merged in:
Authors: Nils Bruin | Reviewers: Simon King
Report Upstream: N/A | Work issues:
Branch: | Commit:
u/SimonKing/ticket/15506 | 614777716fa30b68fd22322435cc273430209f7d
Dependencies: #15432 | Stopgaps:
-------------------------------------+-------------------------------------
Changes (by SimonKing):
* status: needs_review => positive_review
* commit: e23ec990e914edea0cff655ff188716279b33afc =>
614777716fa30b68fd22322435cc273430209f7d
* branch: u/nbruin/ticket/15506 => u/SimonKing/ticket/15506
* reviewer: => Simon King
Comment:
I have added the example from commit:2 as a doc test (otherwise the fix
wouldn't be tested against).
All tests pass (including the new one), and the code makes sense. I only
wonder if we can use Python's trashcan in a different more efficient way
(such as to avoid the creation of a list of length two during deletion of
a dictionary item). But I think this ticket is about fixing a bug in the
first place, and if we see the need for yet more efficiency, we can open
another ticket.
I.e.: Positive review.
--
Ticket URL: <http://trac.sagemath.org/ticket/15506#comment:26>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/groups/opt_out.
