#15506: Fix another "recursion depth exceeded" in memory deallocation for weak
dictionaries
-------------------------------------+-------------------------------------
Reporter: nthiery | Owner:
Type: defect | Status: needs_review
Priority: major | Milestone: sage-6.1
Component: performance | Resolution:
Keywords: | Merged in:
Authors: | Reviewers:
Report Upstream: N/A | Work issues:
Branch: | Commit:
u/nbruin/ticket/15506 | e23ec990e914edea0cff655ff188716279b33afc
Dependencies: | Stopgaps:
-------------------------------------+-------------------------------------
Comment (by SimonKing):
Replying to [comment:16 nbruin]:
> Concerning additional imports and Calcul-math things:
>
> None of that is directly effected by commits on this ticket, so it has
to from the state of "master" on which this branch is based.
OK, so, it is a bug in the plugins.
> This ticket is only meant to change `weak_dict.pyx` and does not
introduce any import statements there. Feel free to use the commits here
to build a new branch based on a different tree if there are things in the
way (note that #15432 has been merged in the branch here; without it
there's only one commit here)
And now I am really confused.
In #15432, you introduce a weak reference from the callback to the weak
value dictionary. Namely, on #15432, you point out that when passing the
weak value dictionary to the callback via a closure then there are
examples requiring many garbage collections to clear a weak value
dictionary.
Now, you revert this change. Can you explain why you did so? Doesn't this
re-introduce the problem that you fixed in #15432? If not: Why not? And
why did you merge #15432 into this branch? What is left from #15432 in the
HEAD of this branch?
--
Ticket URL: <http://trac.sagemath.org/ticket/15506#comment:17>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/groups/opt_out.
