#14711: Weak references in the coercion graph
-------------------------------------+-------------------------------------
Reporter: jpflori | Owner: davidloeffler
Type: defect | Status: needs_review
Priority: critical | Milestone: sage-6.1
Component: number fields | Resolution:
Keywords: memleak, number | Merged in:
field, QuadraticField | Reviewers: Jean-Pierre Flori
Authors: Simon King | Work issues:
Report Upstream: N/A | Commit:
Branch: | 0af59ea93689cb6abb9d3fae0f1cf11f2aee5cca
u/jpflori/ticket/14711 | Stopgaps:
Dependencies: |
-------------------------------------+-------------------------------------
Comment (by SimonKing):
PS: The review commit looks ok to me. I only wonder: Should a doc string
ending with a test also end with a blank line? I thought that the usual
thing to do in Sage (but not official standard) is this
{{{
#!python
def f1(...):
"""
This is some doc
EXAMPLES::
sage: ...
...
The doc ends with normal text and hence without blank line
"""
return None
}}}
but
{{{
#!python
def f2(...):
"""
Some doc
EXAMPLES::
sage: ...
There is a concluding example, and after the example is
a blank line::
sage: ...
,,,
"""
return None
}}}
So, I wonder if it is needed that the review commit removes trailing blank
lines. On the other hand, I don't mind if they'll be removed.
--
Ticket URL: <http://trac.sagemath.org/ticket/14711#comment:175>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/groups/opt_out.
