#14711: Weak references in the coercion graph
-------------------------------------+-------------------------------------
Reporter: jpflori | Owner: davidloeffler
Type: defect | Status: needs_review
Priority: critical | Milestone: sage-6.1
Component: number fields | Resolution:
Keywords: memleak, number | Merged in:
field, QuadraticField | Reviewers: Jean-Pierre Flori
Authors: Simon King | Work issues:
Report Upstream: N/A | Commit:
Branch: | 0af59ea93689cb6abb9d3fae0f1cf11f2aee5cca
u/jpflori/ticket/14711 | Stopgaps:
Dependencies: |
-------------------------------------+-------------------------------------
Comment (by tscrim):
Replying to [comment:181 SimonKing]:
> I suppose what we want to test here is in fact that ''internally''
coerce maps are cached, and thus identical objects are used when one
''internally'' asks for the coerce maps.
>
> Hence, I think one should test `F._internal_coerce_map_from(F) is
F._internal_coerce_map_from(F)`, adding a comment that this is just a test
and `_internal_coerce_map_from()` is, well, internal.
Changed.
> > I'm also getting a strange `<BLANKLINE>` in a doctest in `coerce.pyx`,
which is causing a doctest failure. My guess is it's somehow coming from
the warning message...
>
> Hmmm. This needs to be fixed.
I still don't know where this is coming from.
> I think it is almost exactly what we want.
>
> Perhaps with a little refinement:
> ...
That was exactly what I was thinking. Done and I've pushed the changes to
the branch `public/ticket/14711-internal_test`.
However I am getting segfaults in running the tests in
`complex_number.pyx`, `number_field.py`, and others, and I don't know
what's causing it. (I've also merged in `develop`.)
I also don't quite understand why we need to copy the maps given in
`geometry/polyhedron/parent.py` since it is being used in an internal
`_get_action_()`?
--
Ticket URL: <http://trac.sagemath.org/ticket/14711#comment:182>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/groups/opt_out.
