#11211: elliptic curve p-adic L-series claims to default to eclib but doesn't
-------------------------------------+-------------------------------------
Reporter: was | Owner: cremona
Type: defect | Status: needs_review
Priority: major | Milestone: sage-6.1
Component: elliptic curves | Resolution:
Keywords: | Merged in:
Authors: William Stein, | Reviewers: John Cremona
John Cremona | Work issues:
Report Upstream: N/A | Commit:
Branch: | 530027c370dfc82cb2c6a989984c07f1949d5e9b
u/cremona/ticket/11211 | Stopgaps:
Dependencies: #10280 |
-------------------------------------+-------------------------------------
Changes (by jdemeyer):
* work_issues: fix on 32-bit =>
Old description:
> The code for making an elliptic curve p-adic L-series in
> schemes/elliptic_curves/padic_lseries.py starts like this:
> {{{
> def __init__(self, E, p, use_eclib=False, normalize='L_ratio'):
> r"""
> INPUT:
>
> - ``E`` - an elliptic curve
> - ``p`` - a prime of good reduction
> - ``use_eclib`` - bool (default:True); whether or not to use
> John Cremona's ``eclib`` for the computation of modular
> symbols
> }}}
>
> Note that claim that use_eclib defaults to True and the fact that it
> doesn't.
>
> Since eclib is supposed to be correct, and is much faster, it should be
> the default as claimed in the docstring. The fix should be a patch that
> changes the one __init__ line.
>
> Apply only trac_11211-modsym.patch
New description:
The code for making an elliptic curve p-adic L-series in
schemes/elliptic_curves/padic_lseries.py starts like this:
{{{
def __init__(self, E, p, use_eclib=False, normalize='L_ratio'):
r"""
INPUT:
- ``E`` - an elliptic curve
- ``p`` - a prime of good reduction
- ``use_eclib`` - bool (default:True); whether or not to use
John Cremona's ``eclib`` for the computation of modular
symbols
}}}
Note that claim that use_eclib defaults to True and the fact that it
doesn't.
Since eclib is supposed to be correct, and is much faster, it should be
the default as claimed in the docstring. The fix should be a patch that
changes the one `__init__` line.
--
Comment:
What the purpose of the comment
{{{
# 32-bit (see :trac: `11211`)
}}}
the fact that those tests don't work on 32-bit has nothing to do with this
ticket, right?
--
Ticket URL: <http://trac.sagemath.org/ticket/11211#comment:22>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/groups/opt_out.
