#11211: elliptic curve p-adic L-series claims to default to eclib but doesn't
-------------------------------------+-------------------------------------
Reporter: was | Owner: cremona
Type: defect | Status: needs_review
Priority: major | Milestone: sage-6.1
Component: elliptic curves | Resolution:
Keywords: | Merged in:
Authors: William Stein, | Reviewers: John Cremona
John Cremona | Work issues:
Report Upstream: N/A | Commit:
Branch: | 530027c370dfc82cb2c6a989984c07f1949d5e9b
u/cremona/ticket/11211 | Stopgaps:
Dependencies: #10280 |
-------------------------------------+-------------------------------------
Comment (by jdemeyer):
One other small but important comment (possibly for a different ticket,
but I felt I should mention it): do not put Python code inside `sig_on()`,
espcially not if that Python code can raise exceptions. In particular, the
following 3 lines (possibly more) should be outside the `sig_on()` block:
{{{
r = Cusp(r)
d = r.denominator()
n = r.numerator()
}}}
The consequences of this can be severe:
{{{
sage: from sage.libs.cremona.newforms import ECModularSymbol
sage: E = EllipticCurve('11a')
sage: M = ECModularSymbol(E)
sage: M("garbage")
...
TypeError: unable to convert garbage to a rational
sage: pari("1/0")
...
------------------------------------------------------------------------
Unhandled SIGSEGV: A segmentation fault occurred in Sage.
This probably occurred because a *compiled* component of Sage has a bug
in it and is not properly wrapped with sig_on(), sig_off().
Sage will now terminate.
------------------------------------------------------------------------
}}}
I also recommend that the line {{{M("garbage")}}}} should be doctest.
--
Ticket URL: <http://trac.sagemath.org/ticket/11211#comment:23>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/groups/opt_out.
