#15613: Implementation for check of perfectness for
CrystalOfProjectedLevelZeroLSPaths
-------------------------------------+-------------------------------------
Reporter: aschilling | Owner:
Type: enhancement | Status: needs_review
Priority: major | Milestone: sage-6.1
Component: PLEASE CHANGE | Resolution:
Keywords: crystals, | Merged in:
perfectness | Reviewers: Travis Scrimshaw
Authors: Anne Schilling | Work issues:
Report Upstream: N/A | Commit:
Branch: | fad0735d356949ad157845774a902e464eef5182
public/combinat/crystals/perfectness_level_zero_LS_paths-15613| Stopgaps:
Dependencies: |
-------------------------------------+-------------------------------------
Changes (by tscrim):
* commit: 7274e319a7d8df6e0035b0646dcc1ccdd117caf5 =>
fad0735d356949ad157845774a902e464eef5182
* branch: public/combinat/aschilling/15613 =>
public/combinat/crystals/perfectness_level_zero_LS_paths-15613
* reviewer: => Travis Scrimshaw
Comment:
I've pushed some review changes which gives a (marginal) bit of
optimization for level 1 (since typically higher levels fail in the first
`for` loop):
{{{
sage: ct = CartanType(['A',6,2])
sage: La = ct.root_system().weight_space().basis()
sage: LS = CrystalOfProjectedLevelZeroLSPaths(La[1]+La[2])
sage: %timeit LS.is_perfect()
1 loops, best of 3: 3.22 s per loop
}}}
Before:
{{{
sage: %timeit LS.is_perfect()
1 loops, best of 3: 3.32 s per loop
}}}
I've also marked a few tests as `# long time` since they took at least 10
seconds on my computer (with 2 threads). (I've left the
`weyl_group_representation()` alone because it's really starting Gap
that's taking the time.)
If you're happy with my changes, then it's a positive review.
Best,[[BR]]
Travis
----
New commits:
||[[http://git.sagemath.org/sage.git/commit/?id=fad0735|fad0735]]||{{{Optimized
for level 1.}}}||
||[[http://git.sagemath.org/sage.git/commit/?id=5d9971f|5d9971f]]||{{{Marked
more long tests.}}}||
||[[http://git.sagemath.org/sage.git/commit/?id=b7ef94b|b7ef94b]]||{{{Merge
branch 'public/combinat/aschilling/15613' of trac.sagemath.org:sage into
public/combinat/aschilling/15613}}}||
||[[http://git.sagemath.org/sage.git/commit/?id=c1982ee|c1982ee]]||{{{Review
changes.}}}||
||[[http://git.sagemath.org/sage.git/commit/?id=217537d|217537d]]||{{{Merge
branch 'public/combinat/aschilling/15613' of trac.sagemath.org:sage into
public/combinat/aschilling/15613}}}||
--
Ticket URL: <http://trac.sagemath.org/ticket/15613#comment:6>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/groups/opt_out.
