#15609: IntegerVectors_nk.rank() specialization
-------------------------------------+-------------------------------------
Reporter: f.poloni | Owner:
Type: enhancement | Status: needs_review
Priority: trivial | Milestone: sage-6.1
Component: combinatorics | Resolution:
Keywords: integervectors, | Merged in:
rank | Reviewers:
Authors: Federico Poloni | Work issues:
Report Upstream: N/A | Commit:
Branch: | 06856f64cb051c2068d2d6e70f9b4a55f6b87622
u/f.poloni/ticket/15609 | Stopgaps:
Dependencies: |
-------------------------------------+-------------------------------------
Changes (by f.poloni):
* status: needs_work => needs_review
Comment:
I agree with you on all respects (except maybe that I think that for most
sequences the generic inherited `rank` implementation is still better than
no implementation, but that's a minor unrelated issue).
"Return NULL or raise an exception on failure" is an old programming style
debate, but I agree that it should be more Pythonic to raise an exception.
As for the choice of sequences, also in my view it would be good not to
force a specific one on the user, at least in methods that take them as
inputs, but that's a different and broader issue.
Anyway, I have applied your suggested changes (testing for membership with
`x in self`, and that formatting correction in the docs).
----
New commits:
||[[http://git.sagemath.org/sage.git/commit/?id=06856f6|06856f6]]||{{{test
for membership with `x in self`; minor doc formatting change}}}||
--
Ticket URL: <http://trac.sagemath.org/ticket/15609#comment:9>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/groups/opt_out.
