#2217: splitting field function for number fields
-------------------------------------+-------------------------------------
Reporter: jason | Owner: davidloeffler
Type: enhancement | Status: needs_review
Priority: major | Milestone: sage-6.1
Component: number fields | Resolution:
Keywords: | Merged in:
Authors: Jeroen Demeyer | Reviewers: John Cremona,
Report Upstream: N/A | Frédéric Chapoton
Branch: | Work issues:
u/jdemeyer/ticket/2217 | Commit:
Dependencies: | 9e2dd448b2093e9c6e64d33685900f85ab1ede7c
| Stopgaps:
-------------------------------------+-------------------------------------
Comment (by jdemeyer):
Replying to [comment:26 cremona]:
> during the time when my commit was attached to this ticket, it is
possible that other people pulled it and based further work, new tickets
etc, all on my unreviewed commit.
I absolutely understand your point, but I think I indicated that this was
work in progress so I felt it was safe to "rewrite history". Now that it's
`needs_review`, I will no longer rewrite history.
Concerning authorship: I did indeed reset the author name back to myself
(`git commit --amend --author Demeyer`), and that's already rewriting
history.
--
Ticket URL: <http://trac.sagemath.org/ticket/2217#comment:27>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/groups/opt_out.
