#2217: splitting field function for number fields
-------------------------------------+-------------------------------------
Reporter: jason | Owner: davidloeffler
Type: enhancement | Status: needs_work
Priority: major | Milestone: sage-6.1
Component: number fields | Resolution:
Keywords: | Merged in:
Authors: Jeroen Demeyer | Reviewers: John Cremona,
Report Upstream: N/A | Frédéric Chapoton
Branch: | Work issues:
u/jdemeyer/ticket/2217 | Commit:
Dependencies: | c50eb3e1c340702e06b3ecfabbf29e1aa9da7a44
| Stopgaps:
-------------------------------------+-------------------------------------
Changes (by cremona):
* status: positive_review => needs_work
Comment:
Replying to [comment:33 jdemeyer]:
> Thanks, I didn't expect such a quick review.
>
> Am I allowed to add more examples/doctests?
Of course! I think there are already a lot of examples, which I liked.
If you are going to make some more changes I would be happy to look at
them, so I'll now mark the ticket as needs work, and when you are ready
put it back to needs review. While you are at it, the description of the
class containing a pair (polynomial, degree multiple) is slightly
confusing since it refers to other polynomials in the class, whereas you
actually deal with lists of instances of these.
I am currently working on another branch so the next review will not be so
quick!
--
Ticket URL: <http://trac.sagemath.org/ticket/2217#comment:34>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/groups/opt_out.
