#10963: More functorial constructions
-------------------------------------+-------------------------------------
Reporter: nthiery | Owner: stumpc5
Type: enhancement | Status: needs_review
Priority: major | Milestone: sage-6.1
Component: categories | Resolution:
Keywords: days54 | Merged in:
Authors: Nicolas M. Thiéry | Reviewers: Simon King, Frédéric
Report Upstream: N/A | Chapoton
Branch: | Work issues:
public/ticket/10963 | Commit:
Dependencies: #11224, #8327, | 32b3c4e13aca58a7dfc9a33528164a5ef1b273e7
#10193, #12895, #14516, #14722, | Stopgaps:
#13589, #14471, #15069, #15094, |
#11688, #13394, #15150, #15506 |
-------------------------------------+-------------------------------------
Comment (by SimonKing):
Replying to [comment:315 nthiery]:
> I just went through your changes to the guessing, and I am happy with
them. Just one thing: did you have a specific rationale for switching the
value of "was_guessed" to False when it's set by `__classget__`?
Yes. If it is set by `__classget__` then it wasn't guessed. Hence,
"was_guessed" should be false.
Moreover, it makes debugging slightly easier, as the "was_guessed"
attribute tells how the base category class and axiom were obtained:
- If "was_guessed" is missing: handcoded.
- If "was_guessed==True": lazy class attribute was using name mangling.
- If "was_guessed==False": the class was ''explicitly constructed'' in
that way, hence, guessing (and name mangling) was not needed.
> A priori, I meant the value to be True whenever the base category and
axiom was discovered by the system, and not set explicitly in the category
with axiom.
See above: This can still be seen in the absence of "was_guessed".
--
Ticket URL: <http://trac.sagemath.org/ticket/10963#comment:317>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/groups/opt_out.
