#10963: More functorial constructions
-------------------------------------+-------------------------------------
Reporter: nthiery | Owner: stumpc5
Type: enhancement | Status: needs_review
Priority: major | Milestone: sage-6.1
Component: categories | Resolution:
Keywords: days54 | Merged in:
Authors: Nicolas M. Thiéry | Reviewers: Simon King, Frédéric
Report Upstream: N/A | Chapoton
Branch: | Work issues:
public/ticket/10963 | Commit:
Dependencies: #11224, #8327, | 478de48553d203516cddb47e0cb89c34ccc210ee
#10193, #12895, #14516, #14722, | Stopgaps:
#13589, #14471, #15069, #15094, |
#11688, #13394, #15150, #15506 |
-------------------------------------+-------------------------------------
Comment (by nthiery):
Replying to [comment:317 SimonKing]:
> Yes. If it is set by `__classget__` then it wasn't guessed. Hence,
"was_guessed" should be false.
>
> Moreover, it makes debugging slightly easier, as the "was_guessed"
attribute tells how the base category class and axiom were obtained:
> - If "was_guessed" is missing: handcoded.
> - If "was_guessed==True": lazy class attribute was using name mangling.
> - If "was_guessed==False": the class was ''explicitly constructed'' in
that way, hence, guessing (and name mangling) was not needed.
>
> > A priori, I meant the value to be True whenever the base category and
axiom was discovered by the system, and not set explicitly in the category
with axiom.
>
> See above: This can still be seen in the absence of "was_guessed".
Ok; from this discussion it became clear that the name of this
attribute was bad since we did not interpret it in the same way. I
reworked a tiny bit the protocol so that it's less ambiguous, and
improved the doc accordingly.
If all test pass, if you are happy with the above change, and if Nils
and Volker are ok with keeping the guessing strategy, then we could go
back to positive review!
Cheers,
Nicolas
--
Ticket URL: <http://trac.sagemath.org/ticket/10963#comment:319>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/groups/opt_out.
