#15567: Fix Alphabet and improvements to Family
-------------------------+-------------------------------------------------
Reporter: | Owner: sage-combinat
tscrim | Status: needs_info
Type: | Milestone: sage-6.1
defect | Resolution:
Priority: major | Merged in:
Component: | Reviewers:
combinatorics | Work issues:
Keywords: | Commit:
alphabet | baaabd695e6aa168e02ef6ac2d933e9338e663b9
Authors: | Stopgaps:
Travis Scrimshaw |
Report Upstream: N/A |
Branch: |
public/15567 |
Dependencies: |
-------------------------+-------------------------------------------------
Comment (by tscrim):
Your way of doing things only suppresses the commit message that's put on
trac, there is still the merge in the git history. However I'm not for
rewriting history on a branch on a ticket.
I've fixed the errors I found, standardized the exception messages, and
did some other cleanup of documentation in `family.py`.
I swap the arguments to be consistent with `PolynomialRing` and because it
makes it more user-friendly (at least less requirement of the user to look
at the doc).
As I believe you are aware, `name` is not used as a `prefix`, so we let it
be (and if you meant `names`, then see Vincent's request).
I don't exactly think `Alphabet` should be in the global namespace since
it's not a class, but it doesn't bother me leaving it around since it is a
natural (historical) guess/entry point (and if you want to deprecate it,
please do so on another ticket).
Best,[[BR]]
Travis
--
Ticket URL: <http://trac.sagemath.org/ticket/15567#comment:27>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/groups/opt_out.
