#15567: Fix Alphabet and improvements to Family
-------------------------+-------------------------------------------------
Reporter: | Owner: sage-combinat
tscrim | Status: needs_info
Type: | Milestone: sage-6.1
defect | Resolution:
Priority: major | Merged in:
Component: | Reviewers: Nathann Cohen
combinatorics | Work issues:
Keywords: | Commit:
alphabet | baaabd695e6aa168e02ef6ac2d933e9338e663b9
Authors: | Stopgaps:
Travis Scrimshaw |
Report Upstream: N/A |
Branch: |
public/15567 |
Dependencies: |
-------------------------+-------------------------------------------------
Changes (by ncohen):
* reviewer: => Nathann Cohen
Comment:
> Your way of doing things only suppresses the commit message that's put
on trac, there is still the merge in the git history. However I'm not for
rewriting history on a branch on a ticket.
I do not understand. Why would it suppress the commit message put on trac
? Trac is perfectly able to display two commits at once ?.. `O_o`
And there is absolutely no history rewriting going on. I am just telling
you how I avoid compiling commits based on old beta releases, which seemed
to be a problem for you.
> I've fixed the errors I found, standardized the exception messages, and
did some other cleanup of documentation in `family.py`.
I see.
> I swap the arguments to be consistent with `PolynomialRing` and because
it makes it more user-friendly (at least less requirement of the user to
look at the doc).
I think that's a terrible behaviour.
> As I believe you are aware, `name` is not used as a `prefix`, so we let
it be (and if you meant `names`, then see Vincent's request).
I meant 'names', of course.
Well.
At least now there is some doc in this function.
> I don't exactly think `Alphabet` should be in the global namespace since
it's not a class, but it doesn't bother me leaving it around since it is a
natural (historical) guess/entry point (and if you want to deprecate it,
please do so on another ticket).
I actually thought of deprecating "build_alphabet". Looks like a bad think
to put in the global namespace.
Okay, positive review to that, and those methods are a bit better now than
they were when we began this patch `:-P`
Nathann
P.S. : I will add a commit in a second to fix 2 typos
--
Ticket URL: <http://trac.sagemath.org/ticket/15567#comment:28>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/groups/opt_out.
