#15730: small problems with CHomP, followup to #15161
-------------------------------------+-------------------------------------
       Reporter:  jhpalmieri         |        Owner:
           Type:  defect             |       Status:  positive_review
       Priority:  major              |    Milestone:  sage-6.2
      Component:  algebraic          |   Resolution:
  topology                           |    Merged in:
       Keywords:                     |    Reviewers:  Travis Scrimshaw
        Authors:  John Palmieri      |  Work issues:
Report Upstream:  N/A                |       Commit:
         Branch:                     |  b02b283e6a3da0159708b7a373df1a96c9265f1a
  u/jhpalmieri/chain                 |     Stopgaps:
   Dependencies:                     |
-------------------------------------+-------------------------------------
Changes (by tscrim):

 * status:  needs_review => positive_review
 * reviewer:   => Travis Scrimshaw


Comment:

 LGTM. Just to note, I'm getting two errors, which weren't there before I
 installed the CHomP spkg, but the first is noted in #12607:
 {{{
 sage -t chain_complex.py
 **********************************************************************
 File "chain_complex.py", line 1135, in
 sage.homology.chain_complex.ChainComplex_class.homology
 Failed example:
     D.homology()
 Expected:
     {0: 0, 1: 0, 4: 0, 5: 0}
 Got:
     {}
 **********************************************************************
 File "chain_complex.py", line 1397, in
 sage.homology.chain_complex.ChainComplex_class.torsion_list
 Failed example:
     C.torsion_list(5)
 Expected:
     [(2, [1]), (3, [3])]
 Got:
     [(2, []), (3, [])]
 **********************************************************************
 }}}

--
Ticket URL: <http://trac.sagemath.org/ticket/15730#comment:3>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica, 
and MATLAB

-- 
You received this message because you are subscribed to the Google Groups 
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/groups/opt_out.

Reply via email to