#12141: Implement finite algebras
-------------------------------------+-------------------------------------
Reporter: johanbosman | Owner: AlexGhitza
Type: enhancement | Status: needs_review
Priority: major | Milestone: sage-6.2
Component: algebra | Resolution:
Keywords: sd51 | Merged in:
Authors: Johan Bosman, | Reviewers:
Peter Bruin, Michiel Kosters | Work issues:
Report Upstream: N/A | Commit:
Branch: | 71f53cffc4943f5a4849bb4d051f0d6d31e2fa57
public/algebras/finite_algebras-12141| Stopgaps:
Dependencies: |
-------------------------------------+-------------------------------------
Changes (by tscrim):
* commit: ac731d2558e25e322bc0e68c5e146ec71b7a8dad =>
71f53cffc4943f5a4849bb4d051f0d6d31e2fa57
* branch: u/pbruin/12141-FiniteAlgebra =>
public/algebras/finite_algebras-12141
Comment:
Okay, I've done a review and it looks good overall. However when running
some of the test suites, I realized that the morphisms weren't setup like
the others in Sage, so I've reworked them in my review. It's not perfect,
but IMO morphisms in general need some work. Other than that, it's some
documentation and minor code tweaks. If you're happy with my changes, then
it's a positive review.
----
New commits:
||[http://git.sagemath.org/sage.git/commit/?id=baa9c866663ed20d0b97499919dd06d627890435
baa9c86]||{{{Merge branch 'u/pbruin/12141-FiniteAlgebra' of
trac.sagemath.org:sage into public/algebras/finite_algebra-12141}}}||
||[http://git.sagemath.org/sage.git/commit/?id=9052b7cce2301671c8ef5333849be7e67093ab17
9052b7c]||{{{Partial work on refactoring morphisms.}}}||
||[http://git.sagemath.org/sage.git/commit/?id=809ab1a7c91a08b5950cbaa1c44b1848592f6b15
809ab1a]||{{{Merge branch 'develop' into
public/algebras/finite_algebra-12141}}}||
||[http://git.sagemath.org/sage.git/commit/?id=c089db15e8b092f7b0711620a8c8c5658f8fd1dc
c089db1]||{{{Merge branch 'develop' of trac.sagemath.org:sage into
public/algebras/finite_algebra-12141}}}||
||[http://git.sagemath.org/sage.git/commit/?id=71f53cffc4943f5a4849bb4d051f0d6d31e2fa57
71f53cf]||{{{Finished implementing homsets for finite algebras.}}}||
--
Ticket URL: <http://trac.sagemath.org/ticket/12141#comment:21>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/groups/opt_out.
