#12141: Implement finite algebras
-------------------------------------+-------------------------------------
Reporter: johanbosman | Owner: AlexGhitza
Type: enhancement | Status: needs_review
Priority: major | Milestone: sage-6.2
Component: algebra | Resolution:
Keywords: sd51 | Merged in:
Authors: Johan Bosman, | Reviewers:
Peter Bruin, Michiel Kosters | Work issues:
Report Upstream: N/A | Commit:
Branch: | 42e2f4ef1a2a86864c0e5f08e7c247763842a553
public/algebras/finite_algebras-12141| Stopgaps:
Dependencies: |
-------------------------------------+-------------------------------------
Comment (by pbruin):
Hi Travis,
> Okay, I've done a review and it looks good overall. However when running
some of the test suites, I realized that the morphisms weren't setup like
the others in Sage, so I've reworked them in my review. It's not perfect,
but IMO morphisms in general need some work. Other than that, it's some
documentation and minor code tweaks. If you're happy with my changes, then
it's a positive review.
Thanks for looking at this. To me, changing "finite" to "finite-
dimensional" is OK; in commutative algebra and algebraic geometry it is
very common to say "finite ''A''-algebra" for an algebra that is finitely
generated as an ''A''-module, but in a general setting like Sage, it is
possibly ambiguous. Since the base ring is (at least currently) always a
field, "finite-dimensional" is an acceptable way of clarifying this.
I haven't had the time to review your changes in detail, but here are a
few things I noticed:
- you changed "EXAMPLE::" to "EXAMPLES::" in many places where there is
only one example; do you have a reason for this?
- I think it should be "finite-dimensional algebra", not "finite
dimensional algebra", since "finite-dimensional" is used as a single
adjective.
- Are you sure that the inverse of an element should be cached? This
looks like it could waste a lot of memory. My impression is that in
general only properties of parents should be cached. If any inverse
should be cached at all, why not just that of the underlying matrix?
--
Ticket URL: <http://trac.sagemath.org/ticket/12141#comment:25>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/groups/opt_out.
