#15780: Increase Performance in Projective Morphism
-------------------------------------+-------------------------------------
Reporter: drose | Owner: drose
Type: enhancement | Status: needs_review
Priority: minor | Milestone: sage-6.2
Component: algebraic | Resolution:
geometry | Merged in:
Keywords: Projective, | Reviewers: Ben Hutz
Morphism | Work issues:
Authors: Dillon Rose | Commit:
Report Upstream: N/A | 5bafb1b5a5001794afd3c75a2d21797772813d47
Branch: u/drose/15780 | Stopgaps:
Dependencies: |
-------------------------------------+-------------------------------------
Changes (by bhutz):
* status: new => needs_review
* reviewer: => Ben Hutz
Comment:
I haven't looked closely at functionality yet, but there are a few things
that need to be fixed first.
1) There are several doctests that fail with this:
{{{
sage -t --long sage/schemes/elliptic_curves/lseries_ell.py # 1 doctest
failed
sage -t --long sage/schemes/plane_conics/con_field.py # 3 doctests failed
sage -t --long sage/schemes/generic/morphism.py # 3 doctests failed
}}}
It looks like most of these are because the {{{__call__}}} in
generic\morphism first coerces the input point into the domain and the
{{{__call__}}} in projective\morphism does not. Although the elliptic
curve failure seems to be a precision issue.
2) The new functions must have appropriate documentation. See the
developers guide for the appropriate format.
SCORE projective_morphism.py: 91.9% (34 of 37)
Missing documentation:
* line 182: def __call__(self, x, check=True)
* line 187: def _fast_eval(self, x, check=True)
* line 2625: def _fast_eval(self, x, check=True)
3) There are a number of Tab characters in projective_morphism.py
{{{sage -t --long sage/schemes/projective/projective_morphism.py # Tab
character found}}}
--
Ticket URL: <http://trac.sagemath.org/ticket/15780#comment:5>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/groups/opt_out.
