#12630: Add representations of quivers and quiver algebras to sage
-------------------------------------+-------------------------------------
Reporter: JStarx | Owner: AlexGhitza
Type: enhancement | Status: needs_work
Priority: major | Milestone: sage-6.2
Component: algebra | Resolution:
Keywords: algebra, quiver, | Merged in:
module, days49 | Reviewers: Simon King
Authors: Jim Stark, Simon | Work issues: QuiverRepHom must not
King, Mathieu Guay-Paquet, Aladin | implement __call__
Virmaux | Commit:
Report Upstream: N/A | 50eb7bde26c2a0c688e0500918597591097aa0cb
Branch: | Stopgaps:
public/combinat/quivers |
Dependencies: #12412, #12413, |
#14806, #15491, #15623, #15810 |
-------------------------------------+-------------------------------------
Changes (by SimonKing):
* work_issues: Fix QuiverRepElement.__init__ => QuiverRepHom must not
implement __call__
Comment:
I found the problem!
`QuiverRepHom` overrides `__call__`, which is very bad. When implementing
a map, one should only overload `_call_` and `_call_with_args` and a third
method that I forgot and makes, e.g., a ring map applicable to ideals in
the ring.
Why is that a problem in `Parent.__call__`? Well, `Parent.__call__`
assumes that the convert map is well-implemented and thus tries to save a
few CPU cycles by directly calling `_call_` (not `__call__`) of the map.
Obvious solution: Move `QuiverRepHom.__call__` to `QuiverRepHom._call_`
resp. `QuiverRepHom._call_with_args`.
--
Ticket URL: <http://trac.sagemath.org/ticket/12630#comment:221>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/groups/opt_out.
