#8389: Implement MatrixSpace(...)['x']
-------------------------------------+-------------------------------------
Reporter: mmezzarobba | Owner: AlexGhitza
Type: defect | Status: needs_review
Priority: minor | Milestone: sage-6.2
Component: algebra | Resolution:
Keywords: | Merged in:
Authors: Marc Mezzarobba | Reviewers:
Report Upstream: N/A | Work issues:
Branch: | Commit:
u/mmezzarobba/8389-ring_getitem | 8241fd65d1552db6255e911260cf6c3524c6ec8c
Dependencies: | Stopgaps:
-------------------------------------+-------------------------------------
Comment (by nthiery):
Hi Mark!
I went through the changes, and overall it looks good! Thanks so much for
the cleanup!
Some tiny remarks / suggestions:
- Doc of __getitem__
- TODO -> .. TODO
- Is Frac nicer than .fraction_field()?
- Doc of _gen_names, line 2: replacing {{{ZZ['x']}}} by {{{ZZ[sqrt(5)]}}}
could make it more meaninful?
- getitem for a matrix space M: could {{{M[sqrt(5)]}}} be a meaningful
notation to extend the base ring?
If yes, I'd be in favor of completely deprecating {{{M[3]}}} in favor of
{{{M.unrank(3)}}}, in order to eventually allow for the notation
{{{M[sqrt(5)]}}} without ambiguity in the corner case {{{M[1]}}}.
By the way: shall we use the occasion to also move
{{{PrincipalIdealDomain.__getitem__}}} in the corresponding category? Or
are there some principal ideal domains in Sage that are not yet in the
{{{PrincipalIdealDomains}}} category?
Speaking of this method: its documentation says "Create a polynomial or
power series ring over ``self`` and inject the variables into the global
module scope."; the latter statement is wrong, right?
Cheers,
Nicolas
--
Ticket URL: <http://trac.sagemath.org/ticket/8389#comment:12>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/groups/opt_out.
