#15331: Do not try to create embedded number field morphisms for non-embedded
number fields
-------------------------------------+-------------------------------------
Reporter: SimonKing | Owner:
Type: defect | Status: needs_info
Priority: major | Milestone: sage-6.2
Component: number fields | Resolution:
Keywords: | Merged in:
Authors: Simon King | Reviewers:
Report Upstream: N/A | Work issues:
Branch: | Commit:
u/SimonKing/ticket/15331 | 2123372d5c37cfbabd55fb3f1e63afaa5741ea2a
Dependencies: | Stopgaps:
-------------------------------------+-------------------------------------
Comment (by jpflori):
Replying to [comment:3 mmezzarobba]:
> Hi Simon,
>
> I'm trying to review this ticket, but there are a couple of things I
don't understand:
> * why can't `EmbeddedNumberFieldMorphism` try using the algebraic
closure by itself?
> * even if it really can't, is the giant `except` clause on line 6194 of
`number_field.py` necessary?
> * shouldn't
> {{{
> #!python
> Lemb = Lemb.codomain() # number_field_morphisms.pyx:187
> while Lemb.coerce_embedding() is not None:
> Lemb = Lemb.coerce_embedding().codomain()
> ambient_field = pushout(Kemb, Lemb)
> }}}
> read
> {{{
> #!python
> Lemb = Lemb.codomain()
> while Lemb.coerce_embedding() is not None:
> Lemb = Lemb.coerce_embedding().codomain()
> ambient_field = pushout(Kemb, Lemb)
> }}}
> ?
>
> Sorry if these are stupid questions, I'm still trying to learn how this
all works!
>
> My attempt at simplifying the code based on these remarks is at
`u/mmezzarobba/embedded_NF_morphisms`.
>
Any remark on this Simon?
If you're too busy, I'll just have a look for myself and try to take some
action to get this merged.
--
Ticket URL: <http://trac.sagemath.org/ticket/15331#comment:6>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/groups/opt_out.
