#15351: import_statements sometimes fails
-------------------------------------+-------------------------------------
Reporter: vdelecroix | Owner: vdelecroix
Type: defect | Status: needs_work
Priority: major | Milestone: sage-6.2
Component: misc | Resolution:
Keywords: | Merged in:
Authors: Vincent Delecroix | Reviewers:
Report Upstream: N/A | Work issues:
Branch: | Commit:
u/vdelecroix/improve_import_statements|
84df0e328813a0d298020e128590861633436f2a
Dependencies: | Stopgaps:
-------------------------------------+-------------------------------------
Changes (by ncohen):
* status: needs_review => needs_work
Comment:
Helloooooooooooooooooooooooo !!!
Some remarks:
1) Affected ? That's only correct in french I thing. Do you want to
translate "variable assignment" ? But I believe that in this context
messages like "x is defined by <...>" or "x is equal to <...>" would be
clearer.
2) `And one can actually check that FareySymbol and sum are aliases`.
Would be better with {{{:func:`FareySymbol`}}} for the html doc.
3) If there is an option to display the import line for lazy functions
then the output of this function is meant to be copy/pasted. Thus,
shouldn't the Warning line begin with a {{{#}}} ? Otherwise it is
impossible to copy/paste it into Python code.
4) {{{use it has a name}}} : as a name.
5) This function is awful. It may be nice to split it into
{{{identify_module}}}, {{{identify_object_from_module}}},
{{{identify_by_search_through_modules}}},
{{{identify_object_from_source_code}}}, etc ?... Would make the code a bit
clearer `:-P`
6) {{{names_pattern = dict((i,j) for i,j in whatever)}}} can be rewritten
as `{i:j for i,v in whatever}`. Would make your {{{names_pattern}}} line
clearer.
7) `at the beginig`
8) Why this `print_or_update` function ?
I have not understood everything of the code yet, but fixing the things
above might help `^^;`
Nathann
--
Ticket URL: <http://trac.sagemath.org/ticket/15351#comment:11>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/d/optout.
