#15948: DynkinDiagram with crossed nodes and labels
-------------------------------------+-------------------------------------
Reporter: vittucek | Owner:
Type: enhancement | Status: new
Priority: major | Milestone: sage-6.2
Component: combinatorics | Resolution:
Keywords: | Merged in:
Authors: Vít Tuček | Reviewers:
Report Upstream: N/A | Work issues:
Branch: | Commit:
u/vittucek/ticket/15948 | bf72707a19157a9728badae4932a8a1f010c6897
Dependencies: | Stopgaps:
-------------------------------------+-------------------------------------
Changes (by tscrim):
* cc: nthiery, bump (added)
Old description:
> This patch adds set_crossed_nodes and set_node_labels methods to (non-
> affine) Dynkin Diagrams and modifies the _latex_dynkin_diagram (currently
> without docstrings) so the data are actually used by latex.
>
> This convenient notation is used quite often in certain subbranch of
> differential geometry, see e.g. http://arxiv.org/abs/1303.1307
>
> Moreover, there are two small bugfixes:
>
> 1. Documentation is wrong about our convention for arrows in Dynkin
> diagrams.
> 1. Dynkin diagrams for D and E series contain a special character in the
> node name of tikzpicture which TeX doesn't like.
New description:
This patch adds set_crossed_nodes and set_node_labels methods to (non-
affine) Dynkin Diagrams and modifies the _latex_dynkin_diagram (currently
only in type A) so the data are actually used by latex.
This convenient notation is used quite often in certain subbranch of
differential geometry, see e.g. http://arxiv.org/abs/1303.1307
Moreover, there are two small bugfixes:
1. Documentation is wrong about our convention for arrows in Dynkin
diagrams.
1. Dynkin diagrams for D and E series contain a special character in the
node name of tikzpicture which TeX doesn't like.
--
Comment:
I believe it is useful to have the ability to cross out particular nodes
for Dynkin diagrams (I believe the same/similar convention is used for Lie
superalgebras to denote even/odd indices).
However I think the `node_label` is redundant to the `label` and you are
assuming your indexing set is `1, 2, ..., n`, often which it is not.
Similarly, I'm planning to make Dynkin diagrams more immutable (#15739),
so I'd rather have it return a new `DynkinDiagram` when changing the
crossed out nodes. One last point from a quick look-through, for
comparisons with `None` you should do:
{{{
if x is None:
pass
if x is not None:
pass
}}}
I'll check against Kac tonight. Dan and Nicolas might have some more
comments as well.
Best,[[BR]]
Travis
----
Last 10 new commits:
||[http://git.sagemath.org/sage.git/commit/?id=95ae5db3f1b74142b285d646156b6d0c5aa8a1a7
95ae5db]||{{{Add set_node_labels and set_crossed_nodes to
DynkinDiagram}}}||
||[http://git.sagemath.org/sage.git/commit/?id=05b1b19bedc072e036018385c175fef90d3ce838
05b1b19]||{{{Node labels and crossed nodes for type A}}}||
||[http://git.sagemath.org/sage.git/commit/?id=5da4183846cfb4827167bd423ea8c1057a22f57f
5da4183]||{{{Fix coding style in type A}}}||
||[http://git.sagemath.org/sage.git/commit/?id=d872d163705e13facaccd5b5ed3e0d7d725f5cb5
d872d16]||{{{Node labels and crossed nodes for type B}}}||
||[http://git.sagemath.org/sage.git/commit/?id=356dde097d6885b96607577a3e1ec358fba2f8be
356dde0]||{{{Bugfix for type B}}}||
||[http://git.sagemath.org/sage.git/commit/?id=56a74d528139a24cf9069a1a45b250f98df7d772
56a74d5]||{{{Node labels and crossed nodes for type C}}}||
||[http://git.sagemath.org/sage.git/commit/?id=3a2d0cd6e7f204241cf8ef5b4801370eb7fdcc68
3a2d0cd]||{{{Node labels and crossed nodes for type D (plus nicer
diagram)}}}||
||[http://git.sagemath.org/sage.git/commit/?id=7898620c02c0a64caa883f11d2e3be8d54b54897
7898620]||{{{Node labels and crossed nodes for type E}}}||
||[http://git.sagemath.org/sage.git/commit/?id=685addbeec88066d98a4cc05e376b6bbec7600f8
685addb]||{{{Node labels and crossed nodes for type F}}}||
||[http://git.sagemath.org/sage.git/commit/?id=bf72707a19157a9728badae4932a8a1f010c6897
bf72707]||{{{Node labels and crossed nodes for type G}}}||
--
Ticket URL: <http://trac.sagemath.org/ticket/15948#comment:4>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/d/optout.
