#15948: DynkinDiagram with crossed nodes and labels
-------------------------------------+-------------------------------------
       Reporter:  vittucek           |        Owner:
           Type:  enhancement        |       Status:  new
       Priority:  major              |    Milestone:  sage-6.2
      Component:  combinatorics      |   Resolution:
       Keywords:                     |    Merged in:
        Authors:  Vít Tuček          |    Reviewers:
Report Upstream:  N/A                |  Work issues:
         Branch:                     |       Commit:
  u/vittucek/ticket/15948            |  bf72707a19157a9728badae4932a8a1f010c6897
   Dependencies:                     |     Stopgaps:
-------------------------------------+-------------------------------------

Comment (by vittucek):

 Replying to [comment:6 nthiery]:
 >     Hi Vít!
 >
 > Thanks for your work on this. I agree with Travis. Furthermore the
 current implementation introduces quite some duplication, inside the type-
 specific latex methods and inbetween them. I guess this duplication could
 be avoided by factoring out a method, say {{{_latex_node(node, x,y)}}}
 that would handle the writing of the latex string for the node (label,
 crossing out, ...), and then make the type-specific latex methods use it.
 What do you think?
 >
 > Cheers,
 >                                       Nicolas

 The duplication was always there. I just made it more apparent. ;) I
 myself thought about creating such a method when I was coding type E. I'll
 make that change now.

--
Ticket URL: <http://trac.sagemath.org/ticket/15948#comment:8>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica, 
and MATLAB

-- 
You received this message because you are subscribed to the Google Groups 
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/d/optout.

Reply via email to