#15958: Bug in Partition Algebras
-------------------------------------+-------------------------------------
       Reporter:  Bruce              |        Owner:
           Type:  defect             |       Status:  needs_review
       Priority:  minor              |    Milestone:  sage-6.2
      Component:  combinatorics      |   Resolution:
       Keywords:                     |    Merged in:
        Authors:                     |    Reviewers:
Report Upstream:  N/A                |  Work issues:
         Branch:                     |       Commit:
  public/ticket/15958                |  92d3350ed305fe53fcf4eda491138b32b2bd4278
   Dependencies:                     |     Stopgaps:
-------------------------------------+-------------------------------------
Changes (by darij):

 * cc: tscrim, sage-combinat (added)


Comment:

 Good catch! I've improved it a bit. First of all, bugs fixed should be
 doctested to ensure that they don't reappear when someone later copies bad
 code (or for other reasons). Second, there is no good reason to check for
 `len(part_list) > 0` after a call to `part_list[0]`; that test should have
 been removed rather than corrected. (By the way, this was already inside
 an `if len(part_list) > 0` clause...) Finally, the code is (for some
 reason) duplicated in `partition_algebra.py`; I don't have the time to
 track down the reasons of this duplication, but I've fixed the bug over
 there as well.

 Bad news is that someone else will have to review this ticket now. :)

--
Ticket URL: <http://trac.sagemath.org/ticket/15958#comment:7>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica, 
and MATLAB

-- 
You received this message because you are subscribed to the Google Groups 
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/d/optout.

Reply via email to