#15976: IntegerLattice class
-------------------------------------+-------------------------------------
       Reporter:  malb               |        Owner:
           Type:  enhancement        |       Status:  needs_review
       Priority:  major              |    Milestone:  sage-6.2
      Component:  linear algebra     |   Resolution:
       Keywords:                     |    Merged in:
        Authors:  Martin Albrecht    |    Reviewers:
Report Upstream:  N/A                |  Work issues:
         Branch:                     |       Commit:
  u/malb/15976_integer_lattice       |  43d76e8bc29c84c72ab9ebbd1bd65a01d3fccb52
   Dependencies:                     |     Stopgaps:
-------------------------------------+-------------------------------------

Comment (by malb):

 Replying to [comment:15 darij]:
 > Are you guys sure that special characters (such as · and δ) don't break
 the PDF documentation? Just asking.

 It didn't, but now it does. Thanks!

 > What exactly does the `jacobi` method do? Sage does have a Cholesky
 decomposition method, but that's different (yours is rational, which is
 why I'm curious). Any references or explanations? (They should also go
 into the docstring -- also, a doctest on something other than a scalar
 matrix would be nice...)

 I cannot speak for that part of the code as it was taken on-board from the
 2012 GSoC project. It seemed like the only non-trivial contribution and I
 didn't want to delete it. I never touched it. If no-one is comfortable
 with it, we can drop it though. I asked Daniel Krenn to comment (he was
 the mentor on that GSoC project)

 > Finally, I'd suggest not using such a short and generic name for a class
 like `Lattice` which is not likely to be implemented in foreseeable future
 (shouldn't the inexactness of the reals prevent such class from being
 implementable?).

 I don't see the problem with the class itself, that's what namespaces are
 for, right? Lattice as the basic class for lattices (as discrete subgroups
 of RR^n^) seems about right. However, I do take your point with Lattice is
 in the global namespace (i.e. the constructor). Any recommendation?
 ----
 New commits:
 
||[http://git.sagemath.org/sage.git/commit/?id=43d76e8bc29c84c72ab9ebbd1bd65a01d3fccb52
 43d76e8]||{{{added lattices to reference manual and fixed pdf building
 errors}}}||
 ----
 New commits:
 
||[http://git.sagemath.org/sage.git/commit/?id=43d76e8bc29c84c72ab9ebbd1bd65a01d3fccb52
 43d76e8]||{{{added lattices to reference manual and fixed pdf building
 errors}}}||

--
Ticket URL: <http://trac.sagemath.org/ticket/15976#comment:17>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica, 
and MATLAB

-- 
You received this message because you are subscribed to the Google Groups 
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/d/optout.

Reply via email to