#15983: Python 3 preparation: Change names of some function attributes
-------------------------------------+-------------------------------------
       Reporter:  wluebbe            |        Owner:
           Type:  enhancement        |       Status:  positive_review
       Priority:  major              |    Milestone:  sage-6.2
      Component:  distribution       |   Resolution:
       Keywords:  python3            |    Merged in:
        Authors:                     |    Reviewers:
Report Upstream:  N/A                |  Work issues:
         Branch:                     |       Commit:
  u/wluebbe/ticket/15983             |  c03d421098ed3325b71384394b7920056f4d87b1
   Dependencies:                     |     Stopgaps:
-------------------------------------+-------------------------------------
Changes (by wluebbe):

 * status:  needs_review => positive_review
 * commit:  9357384b4355a03e2d8c53767e601b165d6d5e6a =>
     c03d421098ed3325b71384394b7920056f4d87b1
 * branch:  u/ohanar/remove_func_star => u/wluebbe/ticket/15983


Comment:

 I did a rebase on develop to test with a fresh 6.2.beta6.
 {{{
 MAKE='make -j4' make
 ./sage -tp 4 --all --long >logs/sage-ptestlong-develop
 All tests passed!
 ----------------------------------------------------------------------
 Total time for all tests: 2379.2 seconds
 #####
 git fetch trac u/ohanar/remove_func_star:u/ohanar/remove_func_star
 git co u/ohanar/remove_func_star
 git co -b u/wluebbe/ticket/15983
 git rebase develop
 #####
 ./sage -b
 ./sage -tp 4 --all --long >logs/sage-ptestlong-15983
 All tests passed!
 }}}

 My questions (as still being pretty new to Sage):
 * Is it OK to build and test as above?
 * When is it necessary to do {{{make clean; make lib-clean; make}}}
 instead of {{{./sage -b}}}?
 ----
 New commits:
 
||[http://git.sagemath.org/sage.git/commit/?id=2908c631a518169f07f9d1471f9256e4b4a8bf5c
 2908c63]||{{{Change names of some function attributes}}}||
 
||[http://git.sagemath.org/sage.git/commit/?id=108eccc43f4431ba3ebcbc9132295637a1626e05
 108eccc]||{{{added manual changes that were not found by 2to3 tool (in
 .pyx and hasattr)}}}||
 
||[http://git.sagemath.org/sage.git/commit/?id=c03d421098ed3325b71384394b7920056f4d87b1
 c03d421]||{{{remove hack that used func_doc to distinguish cython and
 python functions}}}||

--
Ticket URL: <http://trac.sagemath.org/ticket/15983#comment:14>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica, 
and MATLAB

-- 
You received this message because you are subscribed to the Google Groups 
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/d/optout.

Reply via email to