#15983: Python 3 preparation: Change names of some function attributes
-------------------------------------+-------------------------------------
       Reporter:  wluebbe            |        Owner:
           Type:  enhancement        |       Status:  positive_review
       Priority:  major              |    Milestone:  sage-6.2
      Component:  distribution       |   Resolution:
       Keywords:  python3            |    Merged in:
        Authors:  Wilfried Luebbe,   |    Reviewers:  Frédéric Chapoton, R.
  R. Andrew Ohana                    |  Andrew Ohana
Report Upstream:  N/A                |  Work issues:
         Branch:                     |       Commit:
  u/wluebbe/ticket/15983             |  c03d421098ed3325b71384394b7920056f4d87b1
   Dependencies:                     |     Stopgaps:
-------------------------------------+-------------------------------------

Comment (by ohanar):

 Replying to [comment:14 wluebbe]:
 > I did a rebase on develop to test with a fresh 6.2.beta6.

 In general, you should probably merge in the latest beta rather than
 rebase (this is a change from how sage use to do things to match standard
 git practices). That said, extra merges are unnecessary, so you should try
 to avoid making merges unless there is a merge conflict or an issue is
 only popping up on a more recent version of sage.

 > My questions (as still being pretty new to Sage):
 > * Is it OK to build and test as above?

 Yes, although part of a review is to look at the changes in the code and
 make sure you agree with them.

 > * When is it necessary to do {{{make clean; make lib-clean; make}}}
 instead of {{{./sage -b}}}?

 Use `make` if there have been upgraded packages in the distribution (so
 between most betas/releases), you can use `./sage -b` if the only changes
 between the last time you built have been to the sage library (useful if
 you are working on a feature branch that only touches the sage library).

--
Ticket URL: <http://trac.sagemath.org/ticket/15983#comment:17>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica, 
and MATLAB

-- 
You received this message because you are subscribed to the Google Groups 
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/d/optout.

Reply via email to