#16049: allow pycrypto to build if SAGE_ROOT is in PATH
-------------------------------------+-------------------------------------
       Reporter:  jhpalmieri         |        Owner:
           Type:  defect             |       Status:  needs_review
       Priority:  major              |    Milestone:  sage-6.2
      Component:  packages:          |   Resolution:
  standard                           |    Merged in:
       Keywords:                     |    Reviewers:  Thierry Monteil
        Authors:  John Palmieri      |  Work issues:
Report Upstream:  Reported           |       Commit:
  upstream. No feedback yet.         |  2657a86945987a61ab0153acc1824475152c12e8
         Branch:                     |     Stopgaps:
  u/jhpalmieri/pycrypto_config       |
   Dependencies:                     |
-------------------------------------+-------------------------------------
Changes (by tmonteil):

 * reviewer:   => Thierry Monteil


Old description:

> If `$SAGE_ROOT` is in `$PATH`, then `pycrypto` may fail to build, at
> least on OS X: the command `sh configure` in `setup.py` can mistakenly
> execute `$SAGE_ROOT/configure`.

New description:

 If `$SAGE_ROOT` is in `$PATH`, then `pycrypto` may fail to build: the
 command `sh configure` in `setup.py` can mistakenly execute
 `$SAGE_ROOT/configure`.

--

Comment:

 Your patch both looks correct and fixes the problem. Actually, i
 experienced this problem on Linux, so the mention `on OS X` in `SPKG.txt`
 is useless (and perhaps misleading). I let you fix that small
 documentation issue, and put a positive review.

--
Ticket URL: <http://trac.sagemath.org/ticket/16049#comment:6>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica, 
and MATLAB

-- 
You received this message because you are subscribed to the Google Groups 
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/d/optout.

Reply via email to