#11670: fix number fields being unique parents -- this got broken over the years
-------------------------------------+-------------------------------------
Reporter: was | Owner: davidloeffler
Type: defect | Status: needs_work
Priority: major | Milestone: sage-6.2
Component: number fields | Resolution:
Keywords: | Merged in:
Authors: William Stein | Reviewers: Simon King
Report Upstream: N/A | Work issues:
Branch: | Commit:
u/saraedum/ticket/11670 | cab3fe1eb4c425f0028b221494f95a03199f2936
Dependencies: | Stopgaps:
-------------------------------------+-------------------------------------
Changes (by saraedum):
* commit: => cab3fe1eb4c425f0028b221494f95a03199f2936
Comment:
With the branch I just pushed, I got rid of ``_set_structure``. The
structure of a number field is now always set when it is created. I know
that unpickling of old objects is currently broken, I'm working on a fix.
Anyway, maybe somebody already wants to have a look at what I have done so
far? Any comments would be appreciated.
Should I now add old number field pickles to the pickle jar? I could not
find out how to do this from the reference manual. Or is this somehow done
automagically?
----
New commits:
||[http://git.sagemath.org/sage.git/commit/?id=c9b7129c203f9c73c3959257ac0470c62cd68432
c9b7129]||{{{Removed number field's _set_structure() which breaks
caching}}}||
||[http://git.sagemath.org/sage.git/commit/?id=16aa7ec42263cc6767a6e898e2ea125248a5491b
16aa7ec]||{{{Create number fields in a factory to make sure they are
unique parents.}}}||
||[http://git.sagemath.org/sage.git/commit/?id=835c817cae746755cf8c46fc5c996fb0f7ff1a6f
835c817]||{{{Implemented NumberFieldStructure classes to improve caching
of (absolute) number fields.}}}||
||[http://git.sagemath.org/sage.git/commit/?id=3a11836185f41fbce189ae979ecc6ee0028ab985
3a11836]||{{{Made assume_disc_small part of the key for the number field
cache (as it used to be).}}}||
||[http://git.sagemath.org/sage.git/commit/?id=cab3fe1eb4c425f0028b221494f95a03199f2936
cab3fe1]||{{{added missing docstrings to number field factories}}}||
--
Ticket URL: <http://trac.sagemath.org/ticket/11670#comment:20>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/d/optout.
