#15974: Implement hyperbolic Cartan types
-------------------------------------+-------------------------------------
Reporter: tscrim | Owner: sage-combinat
Type: enhancement | Status: new
Priority: minor | Milestone: sage-6.2
Component: combinatorics | Resolution:
Keywords: hyperbolic root | Merged in:
systems, coxeter | Reviewers:
Authors: Travis Scrimshaw | Work issues:
Report Upstream: N/A | Commit:
Branch: | ae6d01cefde50ef11cc83f13324a2b3ee7d61f66
public/combinat/root_systems/hyperbolic-15974| Stopgaps:
Dependencies: |
-------------------------------------+-------------------------------------
Comment (by nthiery):
Hi Travis!
Just a quick suggestion for less duplication in the code and a better
isolation of the "database" part. Make:
{{{
if index == 1:
dd = CartanType_Rank3Cycle._construct_dynkin_diagram((1,1,2))
elif index == 2:
dd = CartanType_Rank3Cycle._construct_dynkin_diagram((1,1,-22))
elif index == 3:
dd = CartanType_Rank3Cycle._construct_dynkin_diagram((1,1,3))
...
}}}
Into, at the start of the file and with a more specific name than data
if possible:
{{{
data = (None, (1,1,2), (1,1,-22), (1,1,3), ...)
}}}
And in the constructor:
{{{
dd = CartanType_Rank3Cycle._construct_dynkin_diagram(data[i])
}}}
Cheers,
Nicolas
--
Ticket URL: <http://trac.sagemath.org/ticket/15974#comment:7>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/d/optout.
