#15003: calling factorials of RIF
-------------------------------------+-------------------------------------
Reporter: dkrenn | Owner:
Type: defect | Status: positive_review
Priority: minor | Milestone: sage-6.2
Component: numerical | Resolution:
Keywords: factorial RIF | Merged in:
RealIntervalField calling | Reviewers: Ralf Stephan
inconsistent beginner | Work issues:
Authors: amitjamadagni | Commit:
Report Upstream: N/A | fac03faa1b344513c0242b6f3e3c0022809fbe34
Branch: | Stopgaps:
u/rws/ticket/15003 |
Dependencies: |
-------------------------------------+-------------------------------------
Comment (by rws):
Replying to [comment:21 ppurka]:
> From the end user point of view, the behavior is very inconsistent and
depends on whether after all the computations you get back an element from
`QQ` or `ZZ`. This needs to be fixed more generally, and this is why I
said I wasn't ready to give it positive review in comment:11
Well it's not the scope of this ticket, and warrants yet another ticket
which I will happily open in your name.
> My question was: should we fix all these different fields just by
patching them one by one, OR is there a general way to fix all the fields
at one go?
The author has resolved one of these and this deserves a positive review.
It shows that there was a need for it in RIF. We don't know about the
others. Many thanks for bringing up the big picture.
Let me finally remind you of this note in the development manuals:
“The perfect is the enemy of the good”
The point of the review is to ensure that the Sage code guidelines are
followed and that the the implementation is mathematically correct. Please
refrain from aditional feature requests or open-ended discussion about
alternative implementations. If you want the patch written differently,
your suggestion should be a clear and actionable request.
--
Ticket URL: <http://trac.sagemath.org/ticket/15003#comment:22>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/d/optout.
