#14848: Inconsistencies with FreeAlgebra
-------------------------------------+-------------------------------------
Reporter: ppurka | Owner: AlexGhitza
Type: defect | Status: needs_review
Priority: major | Milestone: sage-6.2
Component: algebra | Resolution:
Keywords: | Merged in:
Authors: Travis Scrimshaw | Reviewers:
Report Upstream: N/A | Work issues: fix doctests
Branch: | Commit:
public/algebras/fix_free_algebras-14848|
74734db11fe788440775741de7519e9f2b7f7956
Dependencies: | Stopgaps:
-------------------------------------+-------------------------------------
Changes (by tscrim):
* status: needs_work => needs_review
Comment:
Replying to [comment:16 ppurka]:
> I am surprised. I have two questions
>
> 1. Why does this patch affect `categories/rings.py`?
It's just a doctest and it's because I swapped the order when iterating
over the objects (i.e., it became index, coefficient whereas before it was
coefficient, index).
> 2. Can you be more specific with `Exception`? In which case did you run
into the `Exception`? `AttributeError`? Can you include it in a doctest?
There's a doctest in `categories/commutative_ring_ideals.py` which tries
to pass off (incorrectly) `Partitions(4)` as a commutative ring, but the
`is_Algebra` fails with a `TypeError`. However, it could also fail with
other errors and I didn't want the `is_Algebra` to error out for similar
reasoning to a `__contains__()` check. We can add additional doctests to
`is_Algebra` but I think we're already covered by other parts of the
library.
--
Ticket URL: <http://trac.sagemath.org/ticket/14848#comment:17>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/d/optout.
