#9341: K.S_units doesn't check for repeated entries
-------------------------------------+-------------------------------------
       Reporter:  syazdani           |        Owner:  davidloeffler
           Type:  defect             |       Status:  needs_review
       Priority:  major              |    Milestone:  sage-6.2
      Component:  number fields      |   Resolution:
       Keywords:  S_units            |    Merged in:
        Authors:  Alex Ghitza        |    Reviewers:
Report Upstream:  N/A                |  Work issues:
         Branch:                     |       Commit:
  u/AlexGhitza/ticket/9341           |  04464c7ef6a6f3867850fb538f417c485871c45c
   Dependencies:                     |     Stopgaps:
-------------------------------------+-------------------------------------

Comment (by pbruin):

 It doesn't seem very robust to rely on a duplicate in the list of prime
 ideals yielding the ''same'' ''S''-unit twice, rather than two (or more)
 different but linearly dependent ''S''-units.  PARI's algorithm probably
 assumes that the input is a list of pairwise distinct prime ideals, so I
 would guess it is safer to apply `uniq()` to the input instead of the
 output.

--
Ticket URL: <http://trac.sagemath.org/ticket/9341#comment:3>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica, 
and MATLAB

-- 
You received this message because you are subscribed to the Google Groups 
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/d/optout.

Reply via email to