#9341: K.S_units doesn't check for repeated entries
-------------------------------------+-------------------------------------
Reporter: syazdani | Owner: davidloeffler
Type: defect | Status: needs_review
Priority: major | Milestone: sage-6.2
Component: number fields | Resolution:
Keywords: S_units | Merged in:
Authors: Alex Ghitza | Reviewers: Peter Bruin
Report Upstream: N/A | Work issues:
Branch: | Commit:
u/AlexGhitza/ticket/9341 | c3d928cab2b6157d14e876b2c8f32d6200ad17dd
Dependencies: | Stopgaps:
-------------------------------------+-------------------------------------
Changes (by pbruin):
* reviewer: => Peter Bruin
Comment:
OK, looks good and all tests pass. The only comment I have is that
`TEST:` should only have a single colon, since there is no doctest
directly following it.
If you want to flatten the commits into one, the easiest way is `git reset
develop` (this forgets that you have made the commits, but keeps the
edits) followed by `git commit -a` and then do a forced push. I agree
that you shouldn't do this in general, but in this case I think it is
fine; I don't expect people have already started to base new work on this.
When you have done one or both of these things, feel free to set this to
positive review.
--
Ticket URL: <http://trac.sagemath.org/ticket/9341#comment:8>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/d/optout.
