#11474: Elliptic curves should be unique parent structures
-----------------------------------+--------------------------
Reporter: SimonKing | Owner: cremona
Type: defect | Status: needs_info
Priority: major | Milestone: sage-6.2
Component: elliptic curves | Resolution:
Keywords: unique parent | Merged in:
Authors: Simon King | Reviewers:
Report Upstream: N/A | Work issues:
Branch: | Commit:
Dependencies: | Stopgaps:
-----------------------------------+--------------------------
Comment (by sbesnier):
pbruin wrote:
>One remark about the approach to follow to make elliptic curves satisfy
unique representation: it turns out that there is an important problem
with using UniqueRepresentation (which Simon's patch introduces) together
with caching (which is certainly used by EllipticCurve), see
https://groups.google.com/forum/#!topic/sage-devel/q5uy_lI11jg. If I
remember correctly, for non-trivial parents it is recommended to use a
UniqueFactory, which gives more flexibility than UniqueRepresentation. (I
personally also understand UniqueFactory better than the __classcall__()
magic of Simon's patch, but that may be simply because I am too familiar
with this part of the internals of Sage.) Maybe Simon or someone else can
elaborate on this point?
If I correctly understand Nils position, it would be better to use a
!UniqueFactory isn't it and not the !UniqueRepresentation ? In that case,
is it usefull to gitify this !UniqueRepresentation patch ?
--
Ticket URL: <http://trac.sagemath.org/ticket/11474#comment:25>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/d/optout.
