#16005: Waste of time in iterator_edges 2
-------------------------+-------------------------------------------------
Reporter: | Owner:
ncohen | Status: positive_review
Type: | Milestone: sage-6.2
enhancement | Resolution:
Priority: major | Merged in:
Component: graph | Reviewers: Vincent Delecroix
theory | Work issues:
Keywords: | Commit:
Authors: | 98286f45fc077f9778708ca3f064a2f5a13853ad
Nathann Cohen | Stopgaps:
Report Upstream: N/A |
Branch: |
public/16005 |
Dependencies: |
#15978 |
-------------------------+-------------------------------------------------
Changes (by vdelecroix):
* status: needs_review => positive_review
Comment:
Replying to [comment:10 ncohen]:
> Do you have a problem with getting this patch merged and dealing with
your optimisations in a different ticket ? You wrote a lot of code which
will take time to review, and there will probably be some design choice to
discuss ?...
My commit is mainly documentation, and the code is copy/paste of the very
same 10 lines... so I do not agree with "You wrote a lot of code". Did you
read it or ran
{{{
if [ $(git log -p -1|grep ^[\+-]|wc -l) -ge 300 ];
then echo "This f******g patch is toooooooo long";
fi
}}}
But for sure I agree that there are some design discussions to have. The
follow up is in #16220.
More seriously, there are many malformations in the documentation
(especially the INPUT/OUTPUT blocks). They concern cdef functions so as
soon as only the reference manual is concerned everything is fine.
Good enough for positive review.
--
Ticket URL: <http://trac.sagemath.org/ticket/16005#comment:11>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/d/optout.
