#16005: Waste of time in iterator_edges 2
-------------------------+-------------------------------------------------
Reporter: | Owner:
ncohen | Status: positive_review
Type: | Milestone: sage-6.2
enhancement | Resolution:
Priority: major | Merged in:
Component: graph | Reviewers: Vincent Delecroix
theory | Work issues:
Keywords: | Commit:
Authors: | 567600b943c81837a5bc525136b55c6f7878327b
Nathann Cohen | Stopgaps:
Report Upstream: N/A |
Branch: |
u/ncohen/16005 |
Dependencies: |
#15978 |
-------------------------+-------------------------------------------------
Comment (by ncohen):
> My commit is mainly documentation, and the code is copy/paste of the
very same 10 lines... so I do not agree with "You wrote a lot of code".
Did you read it or ran
Well, by just reading it I did not get immediately that it was only
copy/paste. And it is code that should be looked at carefully. Don't
worry, in the Graph realm it is not because something is settled "in a
different ticket" that it is buried forever.
I just remembered today that the conversation died on
https://groups.google.com/forum/#!topic/sage-devel/q5uy_lI11jg, and this
is the kind of stuff that needs attention. Burying these things is
criminal.
> But for sure I agree that there are some design discussions to have. The
follow up is in #16220.
Yepyep. I'll go there next, though I believe I still have some answers to
give you on other tickets.
> More seriously, there are many malformations in the documentation
(especially the INPUT/OUTPUT blocks). They concern cdef functions so as
soon as only the reference manual is concerned everything is fine.
Well, it's old code I guess. We'll fix that on the way.
> Good enough for positive review.
Thanks ! If you are looking for things to review, #12867 is getting old
too `:-P`
Nathann
--
Ticket URL: <http://trac.sagemath.org/ticket/16005#comment:13>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/d/optout.
