#15780: Increase Performance in Projective Morphism
-------------------------------------+-------------------------------------
Reporter: drose | Owner: drose
Type: enhancement | Status: needs_work
Priority: minor | Milestone: sage-6.2
Component: algebraic | Resolution:
geometry | Merged in:
Keywords: Projective, | Reviewers: Ben Hutz
Morphism | Work issues:
Authors: Dillon Rose | Commit:
Report Upstream: N/A | 2a4342e2ec2d4d5d3524ab9a7a0aa6510bd66447
Branch: | Stopgaps:
u/drose/ticket/15780 |
Dependencies: #16051, #16168 |
-------------------------------------+-------------------------------------
Changes (by bhutz):
* status: needs_review => needs_work
Comment:
Functionality all tests out fine. A couple minor issues that need to be
addressed
1) _fast_eval does not use the parameter 'check'. Simply remove (from both
_fast_eval functions)
2) @lazy_attribute function needs the documentation string + an example
2b) in the @lazy_attribute. Put the 'prime' and 'degree' inside the 'if'
block so they are only computed if they are needed.
3) There is an extra blank line in _fast_eval for finite fields that can
be removed
4) I'd like to see a few more doctests in _fast_eval. Maybe
a) Powerseries ring
b) quotient ring
You can pull them from comment 8 above.
--
Ticket URL: <http://trac.sagemath.org/ticket/15780#comment:28>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/d/optout.
