#16238: Correct call convention for isogenies
-------------------------------------+------------------------
Reporter: sbesnier | Owner:
Type: defect | Status: new
Priority: major | Milestone: sage-6.2
Component: elliptic curves | Resolution:
Keywords: call isogeny | Merged in:
Authors: Sébastien Besnier | Reviewers:
Report Upstream: N/A | Work issues:
Branch: | Commit:
Dependencies: #12880 | Stopgaps:
-------------------------------------+------------------------
Comment (by defeo):
> However, I'm wondering if this `output_base_ring` argument is used for
any purpose at all. You could try simply removing it; then
`_call_with_args()` is not necessary either.
Same opinion here. Looks like bad design to me: we already have coercion
and `.change_ring` to achieve the same result. These are standard idioms
in Sage, while `output_base_ring` is not.
Except for one single doctest not shown in the ref manual, the third
argument is not even documented.
Since you are at it, you could clean the code of `__call__`. It does a lot
of manual checking of parents, which should be taken care of automatically
by the coercion system if you switch to `_call_`.
--
Ticket URL: <http://trac.sagemath.org/ticket/16238#comment:3>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/d/optout.
