#10963: Axioms and more functorial constructions
-------------------------------------+-------------------------------------
Reporter: nthiery | Owner: stumpc5
Type: enhancement | Status: needs_review
Priority: major | Milestone: sage-6.2
Component: categories | Resolution:
Keywords: days54 | Merged in:
Authors: Nicolas M. Thiéry | Reviewers: Simon King, Frédéric
Report Upstream: N/A | Chapoton
Branch: | Work issues: To be merged
public/ticket/10963-doc- | simultaneously with #15801
distributive | Commit:
Dependencies: #11224, #8327, | 59d73760c528cca3ede00c8b0fc951131c79f473
#10193, #12895, #14516, #14722, | Stopgaps:
#13589, #14471, #15069, #15094, |
#11688, #13394, #15150, #15506, |
#15757, #15759, #16244 |
-------------------------------------+-------------------------------------
Comment (by nthiery):
Hi Travis,
Replying to [comment:689 tscrim]:
> I've merged in (the latest) #16244 and #15919
Thanks! #15919 was not strictly necessary but that's ok.
> and started going through and looking specifically formatting issues and
getting things ready for python3. I'm also reading the new code and doc as
well, but moving pass things I don't understand. I'll do more this
afternoon and evening.
The good thing is that I am now sure that none of the follow up
patches in the queue is going to apply cleanly :-)
No, honestly, I really appreciate the time you are spending improving
the code. But this is to be kept in balance; this ticket is about the
infrastructure, not about rewriting all the category code perfectly.
If you only changed code that was anyway changed by this ticket,
forget this comment.
I proofread your edits and just made a minor changes. For the record,
I have tried indenting long join category output as:
{{{
Join of Category of ...
and Category of ...
}}}
Is there a strong rationale for changing things like:
{{{
if ...:
return ...
else:
return ...
}}}
to
{{{
if ...:
return ...
return ...
}}}
I agree that the latter syntax can express well certain situations;
typically when one gets rid of a special case before attacking the
general case. But other than this, it's a matter of taste, and I would
not change systematically code in one way or the other. Or?
Thanks again,
Nicolas
--
Ticket URL: <http://trac.sagemath.org/ticket/10963#comment:692>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/d/optout.
