#10963: Axioms and more functorial constructions
-------------------------------------+-------------------------------------
Reporter: nthiery | Owner: stumpc5
Type: enhancement | Status: needs_review
Priority: major | Milestone: sage-6.2
Component: categories | Resolution:
Keywords: days54 | Merged in:
Authors: Nicolas M. Thiéry | Reviewers: Simon King, Frédéric
Report Upstream: N/A | Chapoton
Branch: | Work issues: To be merged
public/ticket/10963-doc- | simultaneously with #15801
distributive | Commit:
Dependencies: #11224, #8327, | 59d73760c528cca3ede00c8b0fc951131c79f473
#10193, #12895, #14516, #14722, | Stopgaps:
#13589, #14471, #15069, #15094, |
#11688, #13394, #15150, #15506, |
#15757, #15759, #16244 |
-------------------------------------+-------------------------------------
Comment (by nthiery):
Replying to [comment:693 tscrim]:
> I'm only making changes in the changed code from what I see in the diff.
I'll make sure to indent the long join categories as I go along.
Great, thanks.
> The if/else thing is more of a pet peeve of mine, especially when there
are large indent blocks floating around. IDK, I always feel it makes it
easier to read usually *shrugs*.
Agreed, large indent blocks can be good use case too. I actually tend
to have the same peeve and have a hard time convincing some of my
colleagues about its reasonable use in teaching.
Anyway, for small if/else's like the recent ones where there is not a
compelling reason (a non trivial indentation reduction, or strong
intention to distinguish special case / general case) let's limit
changes and leave the code as it is.
Cheers,
Nicolas
--
Ticket URL: <http://trac.sagemath.org/ticket/10963#comment:695>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/d/optout.
