#16264: Rotate error on childless binay trees
-------------------------------------------------+-------------------------
Reporter: VivianePons | Owner:
Type: defect | Status: new
Priority: major | Milestone: sage-6.2
Component: combinatorics | Resolution:
Keywords: combinat, Tamari, binary | Merged in:
trees, FindStat | Reviewers:
Authors: Viviane Pons | Work issues:
Report Upstream: N/A | Commit:
Branch: | Stopgaps:
Dependencies: |
-------------------------------------------------+-------------------------
Comment (by VivianePons):
Yeah, to be honest a rotate is not defined on every binary tree.
Even so, it still seems quite fair to me to define it as the identity on
the elements where it's not defined. I don't see why it's a problem that
it is not injective. It can say in the doc, that the rotation will be
performed only if t[0] is not none.
I really don't like the return None', it just hides the problem. If you
don't think of checking the result of your operation, it might raise other
weird / non understandable errors later.
--
Ticket URL: <http://trac.sagemath.org/ticket/16264#comment:12>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/d/optout.
