#6014: [with patch, needs work] hexads in S(5,6,12) and mathematical blackjack
---------------------------+------------------------------------------------
Reporter: wdj | Owner: rlm
Type: defect | Status: new
Priority: major | Milestone: sage-4.0.1
Component: coding theory | Keywords: combinatorics, coding theory
---------------------------+------------------------------------------------
Comment(by dgordon):
After reviewing the patch I think that it looks good overall, but there is
one major problem. In setting_up() various global variables are created
with information for minimog_shuffle. The find_hexad() functions take
MINIMOG as an argument, but use the minimog_shuffle global variables.
Right now this is the only minimog implemented, but if minimog_modulo11 is
implemented in the future, other changes would be needed.
Instead of having the global variables separate from the minimog, why not
define a class minimog, which contains all the line, cross, tet, and other
information. This would take care of the above problem, and be better
programming practice.
Also, is it really that difficult to implement minimog_modulo11? I think
the only problem is that then the minimog can't be defined as a matrix
over QQ. Since there aren't any arithmetic operations being done to the
matrix elements, this shouldn't be a real impediment. If the minimogs are
implemented as classes, then a function could be added to convert minimog
elements to strings that handles infinity.
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/6014#comment:3>
Sage <http://sagemath.org/>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--~--~---------~--~----~------------~-------~--~----~
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To post to this group, send email to [email protected]
To unsubscribe from this group, send email to
[email protected]
For more options, visit this group at
http://groups.google.com/group/sage-trac?hl=en
-~----------~----~----~----~------~----~------~--~---