#16237: IncidenceStructureFromMatrix bug
-------------------------+-------------------------------------------------
Reporter: knsam | Owner:
Type: | Status: needs_review
defect | Milestone: sage-6.2
Priority: major | Resolution:
Component: | Merged in:
combinatorics | Reviewers:
Keywords: | Work issues:
Authors: | Commit:
Kannappan Sampath | 44b777a634ee082e1e6f1970d89eac4a2ee67e89
Report Upstream: N/A | Stopgaps:
Branch: |
u/knsam/16237 |
Dependencies: |
-------------------------+-------------------------------------------------
Comment (by ncohen):
Hello !
Several remarks:
1) I do not think you should change the definition of the Paley
matrices... I believe they are well-defined, and if you want a normalized
version of them you should not change their definition but rather
normalize them when you need them. At the very least, you could have an
optional argument "normalize" set to False by default in these functions.
2) You seem to use twice the code to normalize a matrix. I guess the best
would be to write a function that does that, as it can be useful later,
and also useful to the users.
3) There may be a smart way to test if a element of a field is a quadratic
residue, but if you need to enumerate all of them anyway you could begin
by computing the square of all elements of the field, then decide if each
element is a square by testing if it belongs to that list ?...
Nathann
--
Ticket URL: <http://trac.sagemath.org/ticket/16237#comment:13>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/d/optout.
