#16237: IncidenceStructureFromMatrix bug
-------------------------+-------------------------------------------------
Reporter: knsam | Owner:
Type: | Status: needs_info
defect | Milestone: sage-6.2
Priority: major | Resolution:
Component: | Merged in:
combinatorics | Reviewers: Nathann Cohen
Keywords: | Work issues:
Authors: | Commit:
Kannappan Sampath | c496ba610a37e545466746a1177bd95c16f6c069
Report Upstream: N/A | Stopgaps:
Branch: |
u/knsam/16237 |
Dependencies: |
-------------------------+-------------------------------------------------
Changes (by ncohen):
* reviewer: => Nathann Cohen
Comment:
Hello Kannappan !!!
Okayokayokayokay, so you implement more or less Horadam's construction
with a couple of changes of signs. Okay. It would be nice to clean this
file a bit in the future, because right now there is a "return 0" in
functions who claim to return entries of Hadamard matrices `:-P`
Anyway. I agree with what your branch does, and I added a reviewer's
commit in public/16237 to fix a couple of typoes.
1) The first line of the documentation of a function should be a one-line
description of what it does
2) Some people complain where a line ends with spaces ("trailing
whitespaces")
3) Some people complain (the same) when the lines are longer than 80
characters.
4) Some people fight over american/english spelling (but as I never
remember which ones, I did nothing about that `:-P`
Sooooooooo well.
If you agree with my changes, you can either :
1) Add my commit to your branch
2) Change the branch to public/16237 (remember that you are the only one
with writing access to u/knsam/* branches and that everybody can write to
public/* branches
About the doc : it seems to be included already
http://www.sagemath.org/doc/reference/combinat/sage/combinat/matrices/hadamard_matrix.html
HMmmmmmm... Okay, nothing else to say. Good work !
Nathann
P.S. : The custom is the following : usually, the reviewer sets the ticket
to `positive_review`, but in this case I added a commit with small
modifications. So if you agree with what it does, you can set the ticket
to `positive_review` yourself, as you reviewed my changes and I reviewed
yours. And if you do not like something in my commits, the custom is to
discuss it and fight to the death.
--
Ticket URL: <http://trac.sagemath.org/ticket/16237#comment:17>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/d/optout.
